added __getitem__ for iterable behavior #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42B
reviewed
Nov 24, 2018
|
Thanks @kattni ! len makes it play nicer with dotstar library. Is someone going to merge this in? |
|
Looks good, OK to merge. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 18, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.3.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#5 from s-light/add_getitem Updating https://github.com/adafruit/Adafruit_CircuitPython_Logger to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#4 from dastels/master > Merge pull request adafruit/Adafruit_CircuitPython_Logging#3 from dastels/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_AdafruitIO, Adafruit_CircuitPython_Logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i added getitem and len magic functions to the CRGB and CHSV classes.
this way the get iterable and you can access the color-parts in list style.
so for other classes its easier to access the content in the same form as a plain list or tuple.
let me know what you think of this.
this idea came to my mind as i implemented the TLC5957 driver