Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double subtraction of bytes_read from num_to_read in recv_into #183

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

us3r64
Copy link
Contributor

@us3r64 us3r64 commented Jan 15, 2024

No description provided.

@dhalbert
Copy link
Contributor

Thanks for this fix! So this fixes the problem you were seeing, in your experience?

@us3r64
Copy link
Contributor Author

us3r64 commented Jan 15, 2024

Yes, and from what I see it might fix this issue #9 also.

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhalbert dhalbert merged commit c69b6f2 into adafruit:main Jan 15, 2024
1 check passed
@us3r64 us3r64 deleted the fix/socket-recv_into branch January 15, 2024 16:10
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 16, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 6.1.3 from 6.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#185 from us3r64/fix/recv_into-self-_buffer
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#183 from us3r64/fix/socket-recv_into

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants