Add typing and documentation for ScrollingLabel #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
reviewed
May 12, 2022
tekktrik
requested changes
May 13, 2022
Co-authored-by: Alec Delaney <89490472+tekktrik@users.noreply.github.com>
|
Builds are currently failing until an upstream issue can be resolved. |
tekktrik
requested changes
May 18, 2022
|
I think that'll do it. Documentation builds nicely with the latest version of adafruit-blinka-displayio. Thanks for adding the typing. |
tekktrik
approved these changes
May 19, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 20, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_BD3491FS to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_BD3491FS#9 from tekktrik/doc/doc-updates > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Updated gitignore > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 2.1.8 from 2.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_FONA#19 from FoamyGuy/typing_fallback_py37 > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Update .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.2.5 from 2.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#77 from tekktrik/fix/literal-import-failure > Patch .pre-commit-config.yaml Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 6.0.1 from 6.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#29 from FoamyGuy/typing_fallback > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Updated gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.22.4 from 2.22.3: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#170 from rgrizzell/main > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Updated gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.9 from 1.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_RSA#30 from FoamyGuy/py37_typing > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Updated gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed it was missing.