Improved memory efficiency for some text updates to bitmap_label.Label #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 12, 2022 21:18
The tilegrid is also reused if bitmap has not changed. New self._prev_label_direction to allow for tilegrid properties to be set efficiently. Reusing existing bitmap needs clearing due to required use of skip_index on blit(). adafruit#166
…s if a tab is present. adafruit#166
FoamyGuy
approved these changes
Mar 13, 2022
There was a problem hiding this comment.
Looks good to me. Thanks for the improvements @kevinjwalters!
Tested successfully with PyPortal and some variations of the examples scripts.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 14, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 4.1.0 from 3.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#30 from tekktrik/doc/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.22.2 from 2.22.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#167 from kevinjwalters/kjw-efficient-text-updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitmap_label.Label- theself._bitmapandself._tilegridis no longer recreated all the timeBitmap(andTileGrid) using more memory briefly and potentially causing memory fragmentation.self._prev_label_directionto supportlabel_directionproperly.label_directionforRTLwhich would toggle direction if the value was repeatedly set - text reversal is now performed as text is set and not stored._replace_tabs()function also enhanced to only do split/join if tabs are present - this is probably a rare case and it's inefficient to be making new text strings all the time.The most efficient updates are now if the text string is the same character length as the previous value. The bitmap is cleared with
fill(0)and re-written and this can cause flicker. The cognoscenti will be controlling display refresh, of course.