adding filled polygon. Add support for stroke on Polygon #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Nov 17, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 19, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.7.11 from 3.7.10: > Merge pull request adafruit/Adafruit_CircuitPython_BME680#77 from savannahcofer/bugfix/script_timeout Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 10.0.10 from 10.0.9: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#205 from ktnyt/hid-multiple-reports Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.10.0 from 2.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#76 from FoamyGuy/polygon_fill Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.2.0 from 3.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#216 from FoamyGuy/text_box Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Resolves: #63
I opted to make a new FilledPolygon class instead of adding support to existing Polygon directly so that anyone who wants to use the traditional one doesn't have to gain the overhead of an extra Group, or have their code broken if it used some of the superclass TileGrid's attributes.
Not strictly related to the fill support, but I also added the ability to set a
strokeon the existing Polygon (and the new FilledPolygon). All of the other shapes support a stroke value for the thickness of their outline, but Polygon didn't before.