Updating cartesian widget #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagged you @FoamyGuy since you looked at the predecessor PR, but I can review too if you need. |
FoamyGuy
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Looks good to me. Tested successfully on PyPortal Titano.
Thank you @jposada202020!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 14, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.19.14 from 1.19.13: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#84 from jposada202020/updating_cartesian_widget Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.2.0 from 7.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#151 from vladak/exp_backoff_pr > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.13.0 from 1.12.12: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#123 from grypoB/content-length > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the usage of vectorshape usage and the rectangle_helper function in the
__init_.pyfile.tested with the three cartesian examples ,however a second pair of eyes would be helpful! :) tks