Fix day-of-week string indexing to obey Python definition #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python defines "time.struct_time.tm_wday" (the day-of-week element) as "range [0, 6], Monday is 0"; see: https://docs.python.org/3/library/time.html#time.struct_time When expanding the day-of-week integer to a string, the code incorrectly used Sunday-as-0; probably a cut&paste error brought over from C code.
|
Fix #26 for this repo |
FoamyGuy
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
I confirmed this detail in the doc and tested the updated example which coincidentally has different behavior for today's between this fixed version and the current one.
I successfully tested the simpletest modified to today's date on Feather ESP32-S2 TFT. It correctly prints Monday with the new version.
@mew-cx Thanks for reporting this issue and submitting the fix here, as well as compiling the list of other places that may need the fix.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 14, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.1.13 from 2.1.12: > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#27 from mew-cx/mewcx_day_of_week_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.5.11 from 1.5.10: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#26 from FoamyGuy/fix_day_names Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8563 to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8563#5 from FoamyGuy/fix_day_names Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.11 from 0.5.10: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#19 from tekktrik/doc/add-docstrings Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.7 from 2.5.6: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#51 from tannewt/update_readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python defines "time.struct_time.tm_wday" (the day-of-week element) as
"range [0, 6], Monday is 0"; see:
https://docs.python.org/3/library/time.html#time.struct_time
When expanding the day-of-week integer to a string, the code incorrectly
used Sunday-as-0; probably a cut&paste error brought over from C code.