-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations, update documentation #29
Merged
FoamyGuy
merged 10 commits into
adafruit:main
from
tekktrik:doc/typing-and-documentation
Jan 11, 2022
Merged
Add type annotations, update documentation #29
FoamyGuy
merged 10 commits into
adafruit:main
from
tekktrik:doc/typing-and-documentation
Jan 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tekktrik
commented
Jan 11, 2022
- Addresses Issue Missing Type Annotations #27 by adding type annotations
- Updates documentation in a few ways to make things more readable or provide more information
FoamyGuy
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @tekktrik
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 12, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.2.0 from 1.1.13: > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#29 from tekktrik/doc/typing-and-documentation > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#28 from tekktrik/feature/add-eight-slot > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_HTS221 to 1.1.7 from 1.1.6: > Merge pull request adafruit/Adafruit_CircuitPython_HTS221#10 from tekktrik/feature/add-typing > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.4.0 from 3.3.9: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#42 from tekktrik/doc/add-typing > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#43 from tekktrik/feature/add-mode2-reg > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.12.0 from 1.11.2: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#49 from AdamCummick/main Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#31 from aarontusko/fix-write_fuses-busy_wait Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#24 from tekktrik/doc/add-typing > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.5.4 from 0.5.3: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#34 from dannystaple/mov_operators Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.10.5 from 1.10.4: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#94 from kevincon/fix-93 Updating https://github.com/adafruit/Adafruit_CircuitPython_Waveform to 1.3.9 from 1.3.8: > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.