Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #17

Merged
merged 1 commit into from
May 13, 2024
Merged

Update tests #17

merged 1 commit into from
May 13, 2024

Conversation

justmobilize
Copy link
Collaborator

@justmobilize justmobilize commented May 13, 2024

Update some tests to validate exceptions more thoroughly

@justmobilize justmobilize marked this pull request as ready for review May 13, 2024 13:11
@justmobilize
Copy link
Collaborator Author

@dhalbert test updates

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I misunderstood that these would be in the actual library code -- now I see they are in the tests only.

@dhalbert dhalbert merged commit 6d469a9 into adafruit:main May 13, 2024
1 check passed
@justmobilize justmobilize deleted the update-tests branch May 13, 2024 14:43
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 16, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.2.0 from 8.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#202 from justmobilize/add-sendto

Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 3.1.0 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#18 from justmobilize/support-cpython
  > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#17 from justmobilize/update-tests

Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_NTP#34 from justmobilize/use-sedto

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants