-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-try in more cases when socket cannot first be created #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Clarify some documentation. Use sphinx argument documentation style. - Fix some typos. - Remove a few internal comments marking code sections. - Clarify an error message. - Internally, catch exceptions instead of passing them back. - Change one exception. - Update to pylint 3.1.0 so pre-commit can run under Python 3.12
dhalbert
force-pushed
the
socket-retry
branch
2 times, most recently
from
May 11, 2024 01:53
49bc2ec
to
d58ab6b
Compare
This was referenced May 11, 2024
@dhalbert tested and looks good. Quick comments:
|
Yes, I will do that, though since it was error returns on bad args, I don't think it will affect much code. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 13, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 3.0.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#16 from dhalbert/socket-retry Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.7.0 from 7.6.3: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#212 from justmobilize/exception-test-updates Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 3.2.9 from 3.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#192 from justmobilize/exception-test-updates Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover in more cases when a socket cannot be created. This problem is particularly acute on ESP32-S2 on CircuitPython 9.x.x. Use a 9.1.0 build past beta.1 if you would like user-specifiable timeouts. Testing welcome by anyone.
This appears to fix adafruit/circuitpython#9219.
Also:
Test program: