Made chip_select default to None #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested OK with a feather M0 connecting MISO directly to MOSI. |
|
pylint complaining about trailing whitespace: |
dhalbert
requested changes
May 14, 2018
adafruit_bus_device/spi_device.py
Outdated
| @@ -65,7 +65,8 @@ class SPIDevice: | |||
| with device as spi: | |||
| spi.write(bytes_read) | |||
| """ | |||
| def __init__(self, spi, chip_select=None, *, baudrate=100000, polarity=0, phase=0, extra_clocks=0): | |||
| def __init__(self, spi, chip_select=None, *, | |||
There was a problem hiding this comment.
remove trailing space on this line
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 23, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.0 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#17 from cerickson/issue8_spi_nochipselect Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.1.1 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_HID#21 from zzsnzmn/check_circuitpython_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8. I didn't have hardware to fully test at PyCon, please test with BMP280 with/without specifying chip_select.