-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #3 Missing Type Annotations #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh boy, __get__()
and __set__()
! Fun, but also a pain to type annotate, I always need a reference or test script. Feedback below!
resolves #3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Updating https://github.com/adafruit/Adafruit_CircuitPython_BH1750 to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_BH1750#7 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.15 from 1.3.14: > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#22 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.3.0 from 5.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#114 from tekktrik/dev/iterable-io-rework > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_IL91874 to 1.2.9 from 1.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_IL91874#16 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.3.6 from 1.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#17 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1325 to 1.4.7 from 1.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1325#15 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1331 to 1.3.7 from 1.3.6: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1331#16 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1351 to 1.3.7 from 1.3.6: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1351#18 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.2.17 from 1.2.16: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#15 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP007 to 2.1.12 from 2.1.11: > Merge pull request adafruit/Adafruit_CircuitPython_TMP007#13 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_MIDI to 1.0.12 from 1.0.11: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_MIDI#10 from tcfranks/main > Use year duration range for copyright attribution > Keep copyright up to date in documentation
submitted for review/comment : PLEASE be wary with my types in RWBitfields class