-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESP32SPI #65
Merged
Merged
Fix ESP32SPI #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justmobilize
commented
May 1, 2024
brentru
requested changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test routine and associated code looks great, thanks! I have one packaging question.
brentru
approved these changes
May 2, 2024
@dhalbert any changes you want? |
dhalbert
approved these changes
May 3, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 3, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.1.0 from 8.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#199 from anecdata/connect Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.6.0 from 2.5.18: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#65 from justmobilize/fix-esp32spi Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
adafruit_azureiot/device_registration.py
andadafruit_azureiot/iot_mqtt.py
to take passed inssl_context
. This adds support back for ESP32SPI.Tested a few examples, this was my main testing routine (toggling
USE_ONBOARD
). Tested using aUM FeatherS3
+AirLift Featherwing
(for ESP32SPI tests):fixes #55