Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations #34

Merged
merged 7 commits into from
Oct 27, 2021
Merged

Add type annotations #34

merged 7 commits into from
Oct 27, 2021

Conversation

ronnie-llamado
Copy link
Contributor

@ronnie-llamado ronnie-llamado commented Oct 4, 2021 •
edited
Loading

Fixes #33

  • adafruit_azureiot/quote.py:72
  • adafruit_azureiot/quote.py:78
  • adafruit_azureiot/quote.py:82
  • adafruit_azureiot/quote.py:90
  • adafruit_azureiot/quote.py:93
  • adafruit_azureiot/quote.py:96
  • adafruit_azureiot/quote.py:99
  • adafruit_azureiot/quote.py:114
  • adafruit_azureiot/quote.py:119
  • adafruit_azureiot/hmac.py:20
  • adafruit_azureiot/hmac.py:76
  • adafruit_azureiot/hmac.py:93
  • adafruit_azureiot/hmac.py:301
  • adafruit_azureiot/hmac.py:349
  • adafruit_azureiot/hmac.py:355
  • adafruit_azureiot/hmac.py:396
  • adafruit_azureiot/hmac.py:402
  • adafruit_azureiot/hmac.py:432
  • adafruit_azureiot/hmac.py:485
  • adafruit_azureiot/hmac.py:527
  • adafruit_azureiot/device_registration.py:31
  • adafruit_azureiot/iothub_device.py:21
  • adafruit_azureiot/iothub_device.py:185
  • adafruit_azureiot/iothub_device.py:205
  • adafruit_azureiot/iothub_device.py:225
  • adafruit_azureiot/iothub_device.py:244
  • adafruit_azureiot/iothub_device.py:263

@tannewt tannewt requested a review from FoamyGuy October 5, 2021 20:32
FoamyGuy
FoamyGuy requested changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @ronnie-llamado I found that two of the new types don't seem to be supported by the mpy-cross compiler. Have one other question as well.

adafruit_azureiot/iothub_device.py Outdated Show resolved Hide resolved
adafruit_azureiot/quote.py Outdated Show resolved Hide resolved
adafruit_azureiot/iothub_device.py Outdated Show resolved Hide resolved
@ronnie-llamado ronnie-llamado marked this pull request as ready for review October 6, 2021 04:40
FoamyGuy
FoamyGuy reviewed Oct 18, 2021
View reviewed changes
adafruit_azureiot/hmac.py Outdated Show resolved Hide resolved
FoamyGuy
FoamyGuy approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, did not test. I've never used Azure cloud stuff, not sure what all is required to try it out.

@kattni
Copy link
Contributor

kattni commented Oct 27, 2021

Merging this PR. If we run into issues, we'll deal with them as they come. :)

@kattni kattni merged commit 23f7ca7 into adafruit:main Oct 27, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 29, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@61b0168)
895eb32 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.2.9 from 2.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#73 from tekktrik/feature/add-typing
  > add docs link to readme
  > Globally disabled consider-using-f-string pylint check
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.5.8 from 0.5.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#44 from PontusO/revert-41-main
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#45 from jsymons/typing
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#46 from adafruit/not-using-with
  > add docs link to readme
  > Globally disabled consider-using-f-string pylint check

Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.9.4 from 3.9.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#69 from theendlessriver13/add-tests
  > Merge pull request adafruit/Adafruit_CircuitPython_GPS#70 from theendlessriver13/fix-byte-indexing

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.5.6 from 1.5.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#24 from tekktrik/feature/add-typing
  > add docs link to readme
  > Globally disabled consider-using-f-string pylint check
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.4.1 from 2.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#34 from ronnie-llamado/feature/add-type-annotations
  > add docs link to readme
  > Globally disabled consider-using-f-string pylint check
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
3 participants
@ronnie-llamado @kattni @FoamyGuy