Use local vocabulary for VALUES clause #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
302bfab to
0d66199
Compare
So far, a row of a VALUES clause was ignored when one of the values did not occur in the normal vocabulary and could not be folded into an ID (like an integer or a double). Now all rows are considered, and such OOV values are added to the local vocabulary. On the side, the SPARQL parser for the VALUES clause is modified so that it does not produce an `std::string` for each value, like it did so far, but a `TripleComponent`.
0d66199 to
14b279d
Compare
joka921
reviewed
Nov 11, 2022
There was a problem hiding this comment.
I like your improvements very much.
I found some places next to the code you touch that you could improve along the way.
Most of it was not written by you, but I encourage everyone to also make the existing parts of the code better along the way (and so do you).
Refactoring the surrounding code was significantly more work than expected.
joka921
approved these changes
Nov 12, 2022
|
Thanks a lot for this very productive review. I have addressed your final comments, will wait for all our seven build tests to go through without errors, and then merge this PR into the master. |
joka921
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, a row of a VALUES clause was ignored when one of the values did not occur in the normal vocabulary and could not be folded into an ID (like an integer or a double). Now all rows are considered and such OOV values are added to the local vocabulary.
On the side, the SPARQL parser for the VALUES clause is modified so that it does not produce a
std::stringfor each value like it did so far, but aTripleComponent.