Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize headers even more #1785

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Optimize headers even more #1785

merged 3 commits into from
Feb 12, 2025

Conversation

RobinTF
Copy link
Collaborator

@RobinTF RobinTF commented Feb 10, 2025

Follow-up to #1781, eliminates some dead code and optimizes includes again by moving the very expensive include of RuntimeParameters.h into the cpp files.

@sparql-conformance
Copy link

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (551288e) to head (229f7f6).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1785      +/-   ##
==========================================
- Coverage   90.04%   90.02%   -0.03%     
==========================================
  Files         395      395              
  Lines       37909    37900       -9     
  Branches     4264     4262       -2     
==========================================
- Hits        34136    34119      -17     
- Misses       2478     2486       +8     
  Partials     1295     1295              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we have to refactor the RuntimeParameters class soon anyway to make it compatible with C++17 , then we can also tackle an implementation that is much cheaper to compile.

@joka921 joka921 merged commit eef2765 into ad-freiburg:master Feb 12, 2025
23 of 24 checks passed
@RobinTF RobinTF deleted the more-cleanup branch February 12, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants