Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 8 Shift #1

Merged
merged 2 commits into from
Apr 17, 2020
Merged

PHPUnit 8 Shift #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d270e31
Shift phpunit/phpunit dependency
php-shift Apr 17, 2020
53d733e
Shift return type of base TestCase methods
php-shift Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 44 additions & 44 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,49 @@
{
"name": "redu/sns-push",
"type": "project",
"description": "API Wrapper for Amazon SNS PHP SDK",
"keywords": [
"amazon",
"aws",
"sns",
"api"
],
"homepage": "https://github.com/ReduGroup/sns-push",
"license": "MIT",
"autoload": {
"psr-4": {
"SNSPush\\": "src/",
"Tests\\": "tests"
}
},
"authors": [
{
"name": "Alex Currie-Clark",
"email": "alex@onsetsoftware.io",
"role": "Developer"
"name": "redu/sns-push",
"type": "project",
"description": "API Wrapper for Amazon SNS PHP SDK",
"keywords": [
"amazon",
"aws",
"sns",
"api"
],
"homepage": "https://github.com/ReduGroup/sns-push",
"license": "MIT",
"autoload": {
"psr-4": {
"SNSPush\\": "src/",
"Tests\\": "tests"
}
},
{
"name": "Michael Forcer",
"email": "tech@redu.co.uk",
"role": "Developer"
"authors": [
{
"name": "Alex Currie-Clark",
"email": "alex@onsetsoftware.io",
"role": "Developer"
},
{
"name": "Michael Forcer",
"email": "tech@redu.co.uk",
"role": "Developer"
},
{
"name": "Jonathon Henderson",
"email": "tech@redu.co.uk",
"role": "Developer"
}
],
"require": {
"php": ">=7.1",
"aws/aws-sdk-php": "^3.36",
"aws/aws-php-sns-message-validator": "^1.4",
"ext-ctype": "*",
"ext-mbstring": "*",
"ext-json": "*"
},
{
"name": "Jonathon Henderson",
"email": "tech@redu.co.uk",
"role": "Developer"
"require-dev": {
"phpunit/phpunit": "^8.0",
"mockery/mockery": "^1.0",
"doctrine/instantiator": "1.0.5"
}
],
"require": {
"php": ">=7.1",
"aws/aws-sdk-php": "^3.36",
"aws/aws-php-sns-message-validator": "^1.4",
"ext-ctype": "*",
"ext-mbstring": "*",
"ext-json": "*"
},
"require-dev": {
"phpunit/phpunit": "^6.4",
"mockery/mockery": "^1.0",
"doctrine/instantiator": "1.0.5"
}
}
4 changes: 2 additions & 2 deletions tests/deviceTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ class DeviceTest extends TestCase
*/
protected $sns;

public function setUp()
protected function setUp(): void
{
$config = Config::data();

$this->client = Mockery::mock(SnsClient::class);
$this->sns = new SNSPush($config, $this->client);
}

public function tearDown()
protected function tearDown(): void
{
Mockery::close();
}
Expand Down
4 changes: 2 additions & 2 deletions tests/exceptionTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class ExceptionTests extends TestCase
*/
protected $sns;

public function setUp()
protected function setUp(): void
{
$config = [
'account_id' => '01234567890',
Expand All @@ -42,7 +42,7 @@ public function setUp()
$this->sns = new SNSPush($config, $this->client);
}

public function tearDown()
protected function tearDown(): void
{
Mockery::close();
}
Expand Down
4 changes: 2 additions & 2 deletions tests/messageTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
*/
class MessageTest extends TestCase
{
public function setUp()
protected function setUp(): void
{
}

public function tearDown()
protected function tearDown(): void
{
Mockery::close();
}
Expand Down
4 changes: 2 additions & 2 deletions tests/pushTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class PushTest extends TestCase
*/
protected $sns;

public function setUp()
protected function setUp(): void
{
$config = [
'account_id' => '01234567890', // Required
Expand All @@ -43,7 +43,7 @@ public function setUp()
$this->sns = new SNSPush($config, $this->client);
}

public function tearDown()
protected function tearDown(): void
{
Mockery::close();
}
Expand Down