SonarCloud Fixes, main branch (2024.11.07.) #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef8aa2b to
e55e6b5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first set of fixes triggered by SonarCloud's results on our code. It's more or less exploratory at this point, as I want to see how easy it is to track issues in that system.
It was not directly pointed out by SonarCloud, but these changes also allowed me to remove one constructor of
vecmem::device_vectorsince the non-const -> const conversion can actually happen at the level of the views. We don't need to have this type of templated code inside ofdevice_vectoritself. 🤔@stephenswat, I also received some notes about "your" code. Have a look if you like what I did to resolve those reports.