SYCL Memset Fix, main branch (2024.11.06.) #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66042a2 to
014ea8d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
vecmem::sycl::copy::memsetandvecmem::sycl::async_copy::memsetin the absence of::sycl::queue::memset.I came across this issue while making a mistake in #301. Apparently with old SYCL compilers the
memset(...)functions would've never worked. 🤔In the end, checking for whether
::sycl::queue::memsetexists is quite futile by now. With #301 we'll only be able to use compilers that implement the SYCL2020 standard. Which includes::sycl::queue::memset. Nevertheless, this seemed like a simple fix to make.