Add css_class to action links, to avoid changing name, it may result …

…confusing

deprecate changing name

CHANGELOG.rdoc

@@ -1,3 +1,5 @@
+- Add css_class to action links, to avoid changing name, it may result confusing, deprecate name setter
+
 = 3.7.8
 - Rollback previous behaviour when submitting empty values, broken when default_value was added. Default value set in column is not used when trying to save empty value, DB default is used in that case, and save NULL when string is empty, as before.
 - Support operators =, null and not null for :select search_ui, so it's possible to search for NULL with :select search UI.

lib/active_scaffold/data_structures/action_links.rb

@@ -3,9 +3,10 @@ class ActionLinks
     include Enumerable
     attr_accessor :default_type
 
-    def initialize
+    def initialize(name = :root)
       @set = []
-      @name = :root
+      @name = name
+      @css_class = name.to_s.downcase
       @weight = 0
     end
 
@@ -130,8 +131,8 @@ def subgroup(name, label = nil)
 
       if group.nil?
         group = ActiveScaffold::DataStructures::ActionLinks.new
+        group = ActiveScaffold::DataStructures::ActionLinks.new(name)
         group.label = label || name
-        group.name = name
         group.default_type = self.name == :root ? (name.to_sym if %w[member collection].include?(name.to_s)) : default_type
         add_to_set group
       end
@@ -166,8 +167,14 @@ def respond_to_missing?(name, *)
       name !~ /[!?]$/
     end
 
-    attr_accessor :name
+    attr_reader :name
     attr_accessor :weight
+    attr_accessor :css_class
+
+    def name=(value)
+      ActiveSupport::Deprecation.warn "Changing name is deprecated, use css_class to change the class html attribute"
+      self.css_class = value
+    end
 
     protected
 

lib/active_scaffold/helpers/action_link_helpers.rb

@@ -68,7 +68,7 @@ def display_action_link(link, content, record, options)
             group_tag = :li
           end
           content = content_tag(group_tag, :class => html_classes.presence, :onclick => ('' if hover_via_click?)) do
-            content_tag(:div, as_(link.label(record)), :class => link.name.to_s.downcase) << content_tag(:ul, content)
+            content_tag(:div, as_(link.label(record)), :class => link.css_class) << content_tag(:ul, content)
           end
         else
           content = render_action_link(link, record, options)