Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create dashboard servers #40

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

AmrShoukry
Copy link

No description provided.

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for disworse ready!

Name Link
🔨 Latest commit 939fba2
🔍 Latest deploy log https://app.netlify.com/sites/disworse/deploys/673278114b4d1b0008c551d8
😎 Deploy Preview https://deploy-preview-40--disworse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alikehel
Copy link
Member

@AmrShoukry Fix conflicts + the deploy error.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/api/src/common/serialized-types/user.ts 0.00% 15 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
apps/api/src/common/serialized-types/user.ts 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove image from public folder because it's not visible in the deployment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change background color to be the same as direct messages (multiple colors in the project won't be good).

import { ChannelsProps } from "@/types/servers";
import { useRouterState } from "@tanstack/react-router";
import { motion } from "framer-motion";
// import { useRouter } from "@tanstack/react-router";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove any unused imports.

<DiscordToggleDown />
</header>

<div className="custom-scrollbar flex h-[calc(100vh-56px-56px)] flex-col overflow-y-auto bg-mainBlack py-[16px]">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had custom scrollbar defined in the index.css you can use it (we don't have to literally clone discord we can change it a little bit XD).

<div
className={`${isExpanded ? "hidden md:block md:w-full" : "w-full"}`}
>
<div className="custom-scrollbar flex h-[calc(100vh-56px-56px)] flex-col gap-[24px] overflow-y-auto px-[8px] py-[24px]">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make messages start from the bottom AKA newest message and you can scroll up to any old messages (like message FriendChat component).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a problem in the scrolling behavior when I make the order of messages start from the bottom
I am working on it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL you removed my scrollbar still I think it's better to go creative instead of just cloning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice that sorry

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't import Sidebar again it's already a layout in the path /app.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a sever is active I don't need a hover effect, the white bar will be large if it's active and small if it's not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused div Since it doesn't affect the UI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use the Responsive Provider to mange your page because It will be duplication of code otherwise (for example sidebar shouldn't be in the viewport if you open server chat).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"for example sidebar shouldn't be in the viewport if you open server chat"
Sidebar is visible on discord even if you are opening a server chat

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In small screens no it doesn't.

image

@GoatMoaz GoatMoaz added enhancement New feature or request web labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants