-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create dashboard servers #40
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for disworse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@AmrShoukry Fix conflicts + the deploy error. |
Codecov ReportAttention: Patch coverage is
|
apps/web/public/BotAvatar.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove image from public
folder because it's not visible in the deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change background color to be the same as direct messages (multiple colors in the project won't be good).
import { ChannelsProps } from "@/types/servers"; | ||
import { useRouterState } from "@tanstack/react-router"; | ||
import { motion } from "framer-motion"; | ||
// import { useRouter } from "@tanstack/react-router"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove any unused imports.
<DiscordToggleDown /> | ||
</header> | ||
|
||
<div className="custom-scrollbar flex h-[calc(100vh-56px-56px)] flex-col overflow-y-auto bg-mainBlack py-[16px]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had custom scrollbar defined in the index.css
you can use it (we don't have to literally clone discord we can change it a little bit XD).
<div | ||
className={`${isExpanded ? "hidden md:block md:w-full" : "w-full"}`} | ||
> | ||
<div className="custom-scrollbar flex h-[calc(100vh-56px-56px)] flex-col gap-[24px] overflow-y-auto px-[8px] py-[24px]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make messages start from the bottom AKA newest message and you can scroll up to any old messages (like message FriendChat component).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a problem in the scrolling behavior when I make the order of messages start from the bottom
I am working on it
apps/web/src/index.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL you removed my scrollbar still I think it's better to go creative instead of just cloning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice that sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't import Sidebar
again it's already a layout in the path /app
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a sever is active I don't need a hover effect, the white bar will be large if it's active and small if it's not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused div
Since it doesn't affect the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use the Responsive Provider
to mange your page because It will be duplication of code otherwise (for example sidebar shouldn't be in the viewport if you open server chat).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"for example sidebar shouldn't be in the viewport if you open server chat"
Sidebar is visible on discord even if you are opening a server chat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.