V2 Upload Artifact #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* V2 Upload Artifact * Improve logs * Update release * Update test.yml * Update test.yml * Update test.yml * @actions/artifact v0.2.0 package * Add extra YAML test
joshmgross
approved these changes
Apr 28, 2020
yacaovsnc
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upload-artifactaction has been completely rewritten using typescript. The originalv1action is a plugin written in C# that is tied to the runner.As part of the
v2rewrite and to make the action more like a traditional typescript action, the core upload logic has been ported over to the@actions/artifactpackage. This can be found here: https://github.com/actions/toolkit/tree/master/packages/artifactAfter being in preview for over two months, we're ready to merge this into the
masterbranch. Any issues that were reported in #62 have been addressed and there should not be any compat issues betweenv1andv2.All the changes are largely identical to the PR that was merged into the
v2-previewbranch: #54A few minor things have been changed/added
READMEchangingv2-previewtov2.gitattributesso that prettier doesn't complain about line endings on WindowsI don't expect any problems with
v2since all reported issues have been fixed but if need be, we can revert this entire pr so that anyone using@masterisn't broken.