Full release of actions/core 1.6.0 with oidc behavior #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toolkit into main-oidc-client
Added OIDC client functionality in core package
react to OIDC service change.
packages/core/RELEASES.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # @actions/core Releases | |||
|
|
|||
| ### 1.6.0 | |||
| - [Added OIDC Client function `getIDToken`](https://github.com/actions/toolkit/pull/887) | |||
There was a problem hiding this comment.
we need to update the link
packages/core/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@actions/core", | |||
| "version": "1.5.0", | |||
| "version": "1.6.0-beta.0", | |||
There was a problem hiding this comment.
need to update the version.
| return 'https://vstoken.actions.githubusercontent.com/.well-known/openid-configuration' | ||
| } | ||
|
|
||
| describe('oidc-client-tests', () => { |
There was a problem hiding this comment.
I hope we could have some real tests.
TingluoHuang
approved these changes
Sep 28, 2021
jiasli
reviewed
Apr 18, 2024
| } | ||
|
|
||
| private static getRequestToken(): string { | ||
| const token = process.env['ACTIONS_ID_TOKEN_REQUEST_TOKEN'] |
There was a problem hiding this comment.
Using ACTIONS_ID_TOKEN_REQUEST_TOKEN is inconsistent with the document where it suggests using ACTIONS_RUNTIME_TOKEN:
jobs:
job:
runs-on: ubuntu-latest
steps:
- uses: actions/github-script@v6
id: script
timeout-minutes: 10
with:
debug: true
script: |
const token = process.env['ACTIONS_RUNTIME_TOKEN']
const runtimeUrl = process.env['ACTIONS_ID_TOKEN_REQUEST_URL']
core.setOutput('TOKEN', token.trim())
core.setOutput('IDTOKENURL', runtimeUrl.trim())Also see github/docs#32573
Redmishiaomi
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.