fix command escaping #302
Merged
fix command escaping #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also related to actions/runner#267 |
tjamet
added a commit
to actions-go/toolkit
that referenced
this pull request
Jan 17, 2020
There is a fix in actions toolkit: actions/toolkit#302, apply it here as well
tjamet
reviewed
Jan 17, 2020
| // safely append the val - avoid blowing up when attempting to | ||
| // call .replace() if message is not a string for some reason | ||
| cmdStr += `${key}=${escape(`${val || ''}`)}` | ||
| cmdStr += `${key}=${escapeProperty(val)}` |
There was a problem hiding this comment.
I was reading it and thinking that eventually, the function being exported, it is diable for users to run issueCommand('some-command', {'key,1': 'value'}, 'message') that would break the ::name key1=value1,key2=value2::message formatting. would it be something worth taking into account?
There was a problem hiding this comment.
It is a limitation of the command format - defined by the runner - that commas are not allowed within a key name.
Today this limitation does not present a problem. All commands (and keys) are first party - not extensible.
We can relax this constraint in the future needed. But not required for any current scenarios.
TingluoHuang
approved these changes
Jan 18, 2020
shogo82148
added a commit
to shogo82148/go-actions-toolkit
that referenced
this pull request
Oct 3, 2020
backport of actions/toolkit#302
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #301