Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Pin PostgreSQL and Update LLVM #10014

Merged

Conversation

shamil-mubarakshin
Copy link
Contributor

@shamil-mubarakshin shamil-mubarakshin commented Jun 7, 2024

Description

This PR:

  1. temporarily pins PostgreSQL version to 14.12.1 on Windows.
  2. Update LLVM to 18* on Windows

Related issue:

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@mikhailkoliada mikhailkoliada marked this pull request as ready for review June 7, 2024 16:48
@mikhailkoliada
Copy link
Contributor

/azp run windows2019,windows2022

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@shamil-mubarakshin shamil-mubarakshin changed the title [windows] Pin PostgreSQL version [windows] Pin PostgreSQL and Update LLVM Jun 7, 2024
@davidchisnall
Copy link

Please can you link to the update for testing the images to ensure that you don't push an update that deploys a Visual Studio version that's incompatible with the LLVM version that you ship a third time?

fhanau added a commit to cloudflare/workerd that referenced this pull request Jun 15, 2024
The issue has been fixed in actions/runner-images#10014, which has been fully
deployed since. Since this issue happened the last time LLVM was updated within
MSVC, our build might be broken again without warning the next time too.
fhanau added a commit to cloudflare/workerd that referenced this pull request Jun 15, 2024
The issue has been fixed in actions/runner-images#10014, which has been fully
deployed since. Since this issue happened the last time LLVM was updated within
MSVC, our build might be broken again without warning the next time too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants