Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate docker-images #2

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

migrate docker-images #2

wants to merge 9 commits into from

Conversation

panekj
Copy link
Contributor

@panekj panekj commented Jan 27, 2025

Migrating code from https://github.com/catthehacker/docker_images

  • I don't consider git history to be that important, especially in such dynamic workspace where it's usually moving forward with changes so I'm squashing whole import, also not making it a fork so GitHub won't join it to the network
  • Removed more things from the image that I think are not necessary, mostly because they were pulling way too much dependencies like dbus/systemd
  • Updated installations, NodeJS and other software
  • Images are now separated with the ubuntu-* runs-on-like being a tag, it should be more consistent with every other docker image
  • Cleaned up variables and code in scripts to be more consistent
  • Moved build logic and matrix generation to Docker Bake, as I find that is superior method of such complex image building - CI will stay with buildah and build.ps1 (no current plans to remove it)
  • Removed some prerequisite tools building (netavark) and move tool setup to GH action to deduplicate code

@ChristopherHX

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@panekj
Copy link
Contributor Author

panekj commented Jan 27, 2025

i really need to throw out those tools building from the workflow, painful to wait

@panekj

This comment was marked as resolved.

@ChristopherHX

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@ChristopherHX

This comment was marked as resolved.

@ChristopherHX

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@ChristopherHX

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@ChristopherHX

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@ChristopherHX

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@ChristopherHX

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@panekj

This comment was marked as resolved.

@ChristopherHX

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming changes to repository and images
2 participants