Simplify getting current milestone

acteng · Nov 23, 2023 · b3ae959 · b3ae959
1 parent c884cff
commit b3ae959
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/schemes/schemes/domain.py b/schemes/schemes/domain.py
@@ -29,13 +29,11 @@ def update_milestone(self, milestone_revision: MilestoneRevision) -> None:
 
     @property
     def current_milestone(self) -> Milestone | None:
-        current_milestone_revisions = [
-            revision for revision in self._milestone_revisions if revision.effective_date_to is None
+        actual_milestones = [
+            revision.milestone
+            for revision in self._milestone_revisions
+            if revision.observation_type == ObservationType.ACTUAL and revision.effective_date_to is None
         ]
-        actual_milestone_revisions = [
-            revision for revision in current_milestone_revisions if revision.observation_type == ObservationType.ACTUAL
-        ]
-        actual_milestones = [revision.milestone for revision in actual_milestone_revisions]
         return sorted(actual_milestones)[-1] if actual_milestones else None
 
     @property