WIP:Results page #34
WIP:Results page #34
Conversation
src/lib/index.ts
Outdated
| }, | ||
| ); | ||
| return { | ||
| netDifference: proposedSum - existingSum, |
There was a problem hiding this comment.
Given this is derived from these, I would be inclined to remove it but it was convenient to do it this way at first
There was a problem hiding this comment.
What about just a function that sums the score of an array? Two calls to that, then the caller can subtract?
src/lib/index.ts
Outdated
| proposedScores: string[]; | ||
| }; | ||
|
|
||
| export function getCompletedForScorecard( |
There was a problem hiding this comment.
sharing some functionality from elsewhere in order to reuse it and be consistent across our various areas
| <div class="results-grid"> | ||
| <div | ||
| class="header" | ||
| style="--background-color: {headerBackgroundColour}; --font-color:{headerFontColour}" |
There was a problem hiding this comment.
I don't like how I've ended up doing this. Wanted to make sure we used the same colours here but it doesn't really work nicely since afaik I have to put this in every element that pulls them through. We should maybe integrate sass more and just have some styles we can apply to set a background + font colour
There was a problem hiding this comment.
Will look into it, if this is always the same, we shouldn't need vars just to plumb into a svelte style
| > | ||
| Policy Conflicts | ||
| </div> | ||
| <div class="grid-box">{policyCheckComplete}</div> |
There was a problem hiding this comment.
If I had more time I would do this section like I do for the other rows below. It would make this page less cumbersome and we could easily and neatly switch to a link when there is an action for the user
| Net Difference | ||
| </div> | ||
|
|
||
| <LevelOfServiceResults title={"Safety"} existing={2} proposed={68} /> |
There was a problem hiding this comment.
As mentioned this is just stubbed out because we don't have, afaik, a neat answer to where these scores are coming from in our representation of the state
src/lib/index.ts
Outdated
| ); | ||
| } | ||
|
|
||
| export function getScorecardDifference(scorecardState: ScorecardState) { |
src/lib/index.ts
Outdated
| }, | ||
| ); | ||
| return { | ||
| netDifference: proposedSum - existingSum, |
There was a problem hiding this comment.
What about just a function that sums the score of an array? Two calls to that, then the caller can subtract?
| $state[scorecardKey].proposedScores[idx] != "", | ||
| ); | ||
| } | ||
| //@ts-ignore This is a scorecard state |
There was a problem hiding this comment.
Some lint taught me that ts-expect-error should be used instead, because ts-ignore can become unused silently
src/routes/route_check/data.ts
Outdated
| @@ -121,6 +121,7 @@ export interface State { | |||
| pathCheck: Scorecard; | |||
|
|
|||
| pathPlacemakingCheck: Scorecard; | |||
| feedback: string; | |||
There was a problem hiding this comment.
Also need to change getEmptyState
| const headerFontColour = backgroundAndFontCombinations.green.font; | ||
| let headerBackgroundColour = backgroundAndFontCombinations.green.background; | ||
|
|
||
| const policyCheckComplete: boolean = |
There was a problem hiding this comment.
Double check these don't need to be reactive -- whole page should be re-evaluated when switching, but double check SK
| ); | ||
| </script> | ||
|
|
||
| <Breadcrumbs |
| <div class="results-grid"> | ||
| <div | ||
| class="header" | ||
| style="--background-color: {headerBackgroundColour}; --font-color:{headerFontColour}" |
There was a problem hiding this comment.
Will look into it, if this is always the same, we shouldn't need vars just to plumb into a svelte style
ac83e09 to
6facf1a
Compare
First table of result summary page Add next steps Fix broken wording
6facf1a to
546f2d3
Compare
check is not helpful yet; they don't share score types
113ce74 to
abf096d
Compare
|
I got things rebased and passing TS checks. Plenty left to do (started a list in the issue), but solid start -- thanks! |
#24