Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing attribute in role-required-states example #2139

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Fix missing attribute in role-required-states example #2139

merged 3 commits into from
Jan 25, 2024

Conversation

WilcoFiers
Copy link
Member

Issue noticed during the ARIA review

Need for Call for Review: 1 week

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@WilcoFiers
Copy link
Member Author

Forgot to label this, but this went out for review a week ago. Will merge today.

@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Jan 25, 2024
@WilcoFiers WilcoFiers merged commit 86a8b09 into develop Jan 25, 2024
2 checks passed
@WilcoFiers WilcoFiers deleted the WilcoFiers-patch-1 branch January 25, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0066135 0066135 0066135 approved these changes

@tbostic32 tbostic32 tbostic32 approved these changes

@Jym77 Jym77 Jym77 approved these changes

@tombrunet tombrunet tombrunet approved these changes

@carlosapaduarte carlosapaduarte carlosapaduarte approved these changes

Assignees
No one assigned
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WilcoFiers @carlosapaduarte @tombrunet @Jym77 @tbostic32 @0066135