Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aria-required-owned to use gridcell in grid #2137

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

WilcoFiers
Copy link
Member

Feedback from the ARIA WG. Passed example 2 needs to use gridcell, not cell. This isn't required by the owned elements thing, but it is a MUST for the grid role.

Need for Call for Review: 1 week


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Feedback from the ARIA WG. Passed example 2 needs to use gridcell, not cell. This isn't required by the owned elements thing, but it is a MUST for the [grid role](https://w3c.github.io/aria/#grid).
@WilcoFiers WilcoFiers added the Review Call 1 week Call for review for small changes label Jan 25, 2024
@WilcoFiers
Copy link
Member Author

Forgot to label this, but this went out for review a week ago. Will merge today.

@Jym77
Copy link
Collaborator

Jym77 commented Feb 15, 2024

Looks like Call for Review is long done, merging.

@Jym77 Jym77 merged commit 15a48b1 into develop Feb 15, 2024
2 checks passed
@Jym77 Jym77 deleted the required-owned-gridcell branch February 15, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants