Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Element with presentational children has no focusable content" (rule 307n5z) - adding examples #2099

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
aeafb90
invalid-form-field-value-36b590: updating failed example 2.
dan-tripp-siteimprove Apr 4, 2023
5a07973
Merge branch 'develop' into develop
Jym77 Apr 27, 2023
a75c7f8
Merge branch 'act-rules:develop' into develop
dan-tripp-siteimprove May 24, 2023
f920a47
Merge branch 'act-rules:develop' into develop
dan-tripp-siteimprove Jun 22, 2023
75a9878
Merge branch 'act-rules:develop' into develop
dan-tripp-siteimprove Aug 17, 2023
81caf8a
Adding examples to rule presentational-children-no-focusable-content-…
dan-tripp-siteimprove Aug 17, 2023
22022c0
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Sep 1, 2023
78642d0
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Sep 21, 2023
e5f76d7
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Sep 21, 2023
552c293
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Sep 21, 2023
d161d08
Inapplicable Example 4:
dan-tripp-siteimprove Sep 21, 2023
d7ea3d3
Updating Inapplicable Example 4 and references to rule 6cfa84.
dan-tripp-siteimprove Oct 2, 2023
9dd1ac6
Updating Inapplicable Example 1 because of https://github.com/act-rul…
dan-tripp-siteimprove Dec 1, 2023
527cfd9
updating Inapplicable Example 2 based on https://github.com/act-rules…
dan-tripp-siteimprove Dec 1, 2023
9f81ae4
removing Inapplicable Example 3 and replacing it w/ wording in the "b…
dan-tripp-siteimprove Dec 1, 2023
c8d188d
updating Background in response to https://github.com/act-rules/act-r…
dan-tripp-siteimprove Dec 1, 2023
885d122
Merge branch 'develop' into presentational-children-no-focusable-cont…
carlosapaduarte Feb 13, 2024
79268bb
Updating "Inapplicable Example 1" as per https://github.com/act-rules…
dan-tripp-siteimprove Mar 5, 2024
58d6884
Inapplicable Example 1: fixing whitespace.
dan-tripp-siteimprove Mar 5, 2024
da4739a
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Mar 7, 2024
6b0499d
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Mar 7, 2024
6fe0e72
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Mar 7, 2024
22ea612
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Mar 7, 2024
b2c55fe
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Mar 7, 2024
58cd998
Update _rules/presentational-children-no-focusable-content-307n5z.md
dan-tripp-siteimprove Mar 7, 2024
113717d
Merge branch 'develop' into presentational-children-no-focusable-cont…
Jym77 Feb 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update _rules/presentational-children-no-focusable-content-307n5z.md
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
dan-tripp-siteimprove and carlosapaduarte authored Sep 21, 2023

Verified

This commit was signed with the committer’s verified signature.
Fdawgs Frazer Smith
commit e5f76d76c0504ff796ee613daccf807e222b314e
Original file line number Diff line number Diff line change
@@ -180,7 +180,7 @@ None of the roles involved in this semantic table have [presentational children]

#### Inapplicable Example 2

This `<a>` element has a `link` role, which does not have [presentational children][]. So this element - perhaps surprisingly - does not fail this rule, because it's inapplicable. This is the case even though it's invalid HTML. Any time there's a link as the <i>outer</i> element, that will be inapplicable under this rule. (If the elements were switched - that is, if the `<button>` element contained the `<a>` element - then that would fail this rule.)
This `<a>` element has a `link` role, which does not have [presentational children][]. So this element does not fail this rule, because it's inapplicable.

```html
<a href="https://w3.org"><button>W3C Website</button></a>