Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a defintion for essential text change #1916
base: develop
Are you sure you want to change the base?
Adds a defintion for essential text change #1916
Changes from 10 commits
6e74948
88cae51
f6e8dad
8d02d2f
098953c
1d267c1
6ec4c27
3518ba1
269e0a3
93e6dab
017ca8c
ae85e2e
a21c0be
d21a3b7
4cfa666
cb3f8e5
2869186
888d096
580edeb
8a7aed3
0213bb4
15e8c96
8b7d2c4
a3076c5
9544d6e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would something like a clock or a count-down be considered essential. For example on a new years calendar, an auctioning site counting down when the auction closes, or a ticket site counting down to when tickets go on sale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if it is a core functionality of the website then it would be considered essential. E.g., in a web page that is only a large clock counting down to new year then the text change of the clock would be essential.