Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 80f0bf - audio or video avoids automatically playing audio #1655
base: develop
Are you sure you want to change the base?
Update 80f0bf - audio or video avoids automatically playing audio #1655
Changes from 49 commits
2c9e229
f0e2241
728538c
9ef2873
63b4d64
2cc646d
500ebc9
2ec57ce
f3035e0
2e5d3d1
32cf772
b12416b
63cfbf1
eb43a2d
b79d068
5d90f12
1fbcd53
1b3791b
ee1e021
ad6778b
3a86ac0
064b7f8
682fe7d
5c0fec1
0a67ec7
8af6aea
6943774
7bfbffe
81b7f48
a654300
4fc3ff6
f73fed1
bd29173
777d1f8
2b17759
de3e4f9
3c05a2f
51d8c1b
ec0521d
42a68c3
3b92b94
4bb7d79
f53dad9
2850665
8b69d82
83abb41
a5fd2da
d060379
07a01e5
efa91bf
f0eee9a
af10ed2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example somewhat contradicts the idea that whether a failed example fails shouldn't depend on accessibility support. I'm a little worried this example could block implementations that run in Chromium. I know that could happen in axe Pro (although we have no tools testing this today). I'm pretty sure Trusted Tester would be impacted though, as it is tested in Edge.
So from that angle I'm not sure I would want this example in. On the other hand, not having a failed video example in it feels like a problem too. We could possibly wait with this rule until we have this "optional examples" idea worked out. A different option could be to modify the rule so that it isn't just about autocomplay, but more generally about media elements that start playing without user interaction within the first 3 second of the page loading? That feels like a reasonable improvement on this rule anyway, and we could then add videos that get turned on through a script during onload.