Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument accessibility note #1632

Merged
merged 10 commits into from
Jun 25, 2021
Merged

Instrument accessibility note #1632

merged 10 commits into from
Jun 25, 2021

Conversation

Jym77
Copy link
Collaborator

@Jym77 Jym77 commented May 27, 2021

Add a note in the definition of instrument, and the rules using it, to indicate that instruments should be accessible.

Closes issue(s):

Need for Final Call:
This will not require a Final Call (editorial changes)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Final Call period. In case of disagreement, the longer period wins.

@Jym77 Jym77 added Editorial For editorial changes that does not change the meaning of a rule or Glossary term reviewers wanted labels May 27, 2021
@Jym77 Jym77 self-assigned this May 27, 2021
pages/glossary/instrument.md Outdated Show resolved Hide resolved
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button.

Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

pages/glossary/instrument.md Outdated Show resolved Hide resolved
Jym77 and others added 3 commits June 10, 2021 16:24
Co-authored-by: Carlos Duarte <carlosapaduarte@gmail.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
@Jym77 Jym77 dismissed stale reviews from carlosapaduarte and WilcoFiers June 10, 2021 14:25

Change accepted.

@Jym77 Jym77 merged commit 77b0f10 into develop Jun 25, 2021
@Jym77 Jym77 deleted the instrument-accessibility-note branch June 25, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial For editorial changes that does not change the meaning of a rule or Glossary term reviewers wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should "instrument"/"mechanism" be accessible? keyboard actionable?
4 participants