Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --select-found flag #54

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Feb 3, 2023

Easy way to get all available addons to the current environment (or path selection).

Closes #17.

@sbidoul
Copy link
Member

sbidoul commented Feb 3, 2023

CI is now green

Easy way to get all available addons to the current environment (or path selection).

Closes acsone#17.
@yajo
Copy link
Contributor Author

yajo commented Feb 3, 2023

Thanks! I rebased, but it seems you need to approve the run.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #54 (3052f73) into main (a060a18) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   83.77%   84.19%   +0.41%     
==========================================
  Files          17       17              
  Lines         561      563       +2     
  Branches      114      115       +1     
==========================================
+ Hits          470      474       +4     
+ Misses         71       70       -1     
+ Partials       20       19       -1     
Impacted Files Coverage Δ
src/manifestoo/main.py 76.37% <100.00%> (+1.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sbidoul
Copy link
Member

sbidoul commented Feb 3, 2023

LGTM, thanks for the contrib! Can you add a newfragment (news/17.feature)?

@sbidoul
Copy link
Member

sbidoul commented Feb 3, 2023

Ah, and cherry on the cake would be an update to the documentation page: https://github.com/sbidoul/manifestoo/blob/main/docs/addons_selection.md (I'll regenerate CLI reference upon release).

@yajo
Copy link
Contributor Author

yajo commented Feb 7, 2023

Done!

@sbidoul sbidoul merged commit 59a90a0 into acsone:main Feb 7, 2023
@yajo yajo deleted the add-found-only branch February 9, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifestoo could be use to list all distributed modules for a given Odoo installation
2 participants