Downgrade PHPUnit to version used by Drupal core (~4.8) #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grasmash
reviewed
Jan 18, 2017
| @@ -21,7 +21,7 @@ | |||
| "drupal/console": "^1.0.0-rc13", | |||
| "phing/phing": "^2.15.0", | |||
| "php": ">=5.6", | |||
| "phpunit/phpunit": "^5.5.4", | |||
| "phpunit/phpunit": "~4.8", | |||
There was a problem hiding this comment.
Please specify this as a minimum version. E.g., ^4.8
There was a problem hiding this comment.
@grasmash Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhpStorm seems to be incompatible with PhpUnit 5 (or some of its dependencies). Can we downgrade to the version used by Drupal core (~4.8)? Tracking core on that point seems like the safest thing to do anyway, since many people will want to write unit tests that will work on the Drupal.org testbot and some people may even want to run core's unit tests; and the safest thing in both those cases is to use the same version.