Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB updates should always be run before config imports. #930

Merged
merged 3 commits into from
Jan 6, 2017

Conversation

danepowell
Copy link
Contributor

This is sort of a follow-up to #911, since I just saw an example of it failing in the wild.

As I mentioned in that ticket, db updates must be run before configuration imports so that any dependent modules can be enabled. Otherwise there's no way to add a configuration with a dependency on a new module.

Of course it's possible that something in your update hook might depend on a configuration change, in this case you should manually import just the necessary configuration as part of your update hook. This was the best practice with Features in D7 and I don't see any alternative in D8.

@grasmash grasmash added in progress Enhancement A feature or feature request labels Jan 6, 2017
@grasmash
Copy link
Contributor

grasmash commented Jan 6, 2017

@danepowell Is there any sort of documentation change that should be made to accompany this?

@danepowell
Copy link
Contributor Author

We have several lines of documentation before the update step, and I added one more:
https://github.com/acquia/blt/pull/930/files#diff-d6981a61601a737ce906a130556d199fR218

I think that should be sufficient, unless you want to move all of it to a separate readme.

@grasmash grasmash merged commit 3a4d80e into acquia:8.x Jan 6, 2017
@danepowell danepowell deleted the feature/update-order branch December 6, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants