Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #702: Freshly-built project doesn't get a README.md #876

Closed
wants to merge 1 commit into from

Conversation

shahinam
Copy link
Contributor

Fixes #702

Changes:

The rsync-template is done with out overwriting the existing files:

  • When no bolt updates are required, the README.md is there but it is from the blt-project as it is never overwritten
  • When updates are required during the project creation, the README.md is removed because of post-create-project-cmd from blt-project

So, I have selectively remove README.md just before copying the files from templates directory.

@@ -35,6 +35,8 @@

<target name="blt:rsync-template" hidden="true">
<echo>Copying files from BLT's template into your project...</echo>
<!-- Remove the README.md before rsync -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be run every time that somebody performs an update on their local project. Instead, we should put this in the create-project target.

@grasmash grasmash added Enhancement A feature or feature request Bug Something isn't working and removed Enhancement A feature or feature request labels Dec 28, 2016
@shahinam shahinam force-pushed the 702-missing-readme branch from 0e85711 to 0f6d5c8 Compare January 3, 2017 04:12
@shahinam
Copy link
Contributor Author

shahinam commented Jan 3, 2017

@grasmash Thanks, made the requested changes.

@grasmash
Copy link
Contributor

grasmash commented Jan 4, 2017

Replaces #907

@grasmash grasmash closed this Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants