Fixed errors on ACE deploys. #733
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like logoutput is set to "false " rather than "false". |
|
Ah good eye! I was wondering why output was still being logged... Should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to 8.6.0-beta1, deployments to ACE throw this error:
I'm assuming this is due to the addition of this version check, which uses composer: https://github.com/acquia/blt/blob/8.x/phing/tasks/properties.xml#L36
This may not be the most elegant solution, but it eliminates the errors. Another (more performant) solution might be to make the version check a dedicated function that runs only as a dependency of Phing targets that need it (i.e.
update-deltaandversion)Still testing this.