Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate dependencies. #591

Merged
merged 2 commits into from
Oct 19, 2016

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Oct 19, 2016

The template composer.json defines a direct dependency on several packages that are already dependencies of other packages:

  • Drupal Console (dependency of BLT)
  • Drupal Coder (BLT)
  • PHPUnit (BLT)
  • PHPCS (BLT)
  • Composer installers (Drupal Console and Lightning)

Because these dependencies are effectively defined twice, composer throws a warning when you run composer update on a BLT project:

Dependency "drupal/coder" is also a root requirement, but is not explicitly whitelisted. Ignoring.

Right now I think this is a harmless warning, but it could lead to unpredictable behavior if BLT, Drupal console, or Lightning updates or patches one of these dependencies.

Seems like the best solution is to remove them from the project template composer.json, and just allow upstream projects to manage them.

@danepowell
Copy link
Contributor Author

I've confirmed that removing these dependencies from a generated BLT project doesn't actually change the composer.lock, confirming that they were basically superfluous.

@grasmash
Copy link
Contributor

Perhaps we should move a few of these to BLT's composer.json:

  • composer/installers
  • cweagans/composer-patches

@grasmash grasmash added the Enhancement A feature or feature request label Oct 19, 2016
@grasmash grasmash merged commit aaa7229 into acquia:8.x Oct 19, 2016
@danepowell
Copy link
Contributor Author

Yeah, composer-installers comes from both Lightning and Drupal Console. But since I think BLT invokes it directly, we should move it to BLT's composer.json.

@danepowell danepowell deleted the feature/dependency-dupes branch December 6, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants