Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak simplesaml config. #579

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Conversation

danepowell
Copy link
Contributor

Right now, acquia_config.php is basically cruft left over from the config setup. This is a little confusing because some people (i.e. yours truly) might assume that it's being dynamically included somehow.

This makes it a little cleaner.

I still need to test this.

@grasmash
Copy link
Contributor

@danepowell tell me when you've tested it :)

@grasmash grasmash added the Enhancement A feature or feature request label Oct 18, 2016
@danepowell
Copy link
Contributor Author

Just tested and working great!

@dooleymatt feel free to comment since you wrote this originally but I'm pretty sure it's the right way to go.

@dooleymatt
Copy link
Contributor

@danepowell yeah, much better.

@grasmash grasmash merged commit c442629 into acquia:8.x Oct 18, 2016
@danepowell danepowell deleted the feature/simplesaml branch December 6, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants