-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3998: Support PHP 7.4 #3997
Conversation
daef717
to
9a4d489
Compare
241b11f
to
5814e53
Compare
Tests fail as expected, waiting for upstream fix... |
Blocked on a new release of Robo, which likely won't come until after consolidation/robo#924 is resolved. |
#924 has now been merged to master; the backport to the 1.x branch is consolidation/robo#925. |
Please try with HEAD of the 1.x branch, and, if possible, HEAD of master. |
@greg-1-anderson thanks for the quick response. Head of 1.x is still failing, which makes sense as this commit hasn't been backported: consolidation/robo@2d2a4f6 I'm not able to test the master branch with BLT because of conflicting Symfony dependencies. Drupal 8 uses Symfony 3 and Drupal 9 uses 4.4.3, while Robo master requires 4.4.4+. |
Whoops, I thought I already had #922 backported to the 1.x branch, but I forgot. That's coming right up. I'll try to loosen up some of the master branch requirements at a future date. |
OK, the 1.x branch now has consolidation/robo#922 on it. |
Yay, I can confirm that Robo 1.x-dev fixes it! |
Cool I will make a release pretty soon. |
Tagged 1.4.12. |
Woot, thanks! I'll bump our dependency on Robo to 1.4.12. FYI, we'll try to switch to Robo 2 after updating our dependencies to support Drupal 9, and sorting out the conflict with Robo's Symfony versions. |
Tagged Robo 2.0.3 with slightly relaxed dependency constraints. Can be required in a project that uses the Drupal 9.0.0-alpha1 lock file. |
This is now blocked on a new release of Drush 10, which also has a PHP 7.4 incompatibility that was recently fixed in dev: drush-ops/drush#4319 |
* Bump Travis CI PHP version. * Bump robo version to support php 7.4. * debug * Update .travis.yml * Drush 10 php 7.4.
Fixes #3998
Commands fail on PHP 7.4, so let's test that.
Also bump Drupal head.