Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3998: Support PHP 7.4 #3997

Merged
merged 9 commits into from
Feb 27, 2020
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Jan 30, 2020

Fixes #3998

Commands fail on PHP 7.4, so let's test that.

Also bump Drupal head.

@danepowell danepowell changed the title Bump Travis CI PHP version. Fixes #3998: Support PHP 7.4 Jan 30, 2020
@danepowell
Copy link
Contributor Author

Tests fail as expected, waiting for upstream fix...

@danepowell
Copy link
Contributor Author

Blocked on a new release of Robo, which likely won't come until after consolidation/robo#924 is resolved.

@greg-1-anderson
Copy link

#924 has now been merged to master; the backport to the 1.x branch is consolidation/robo#925.

@greg-1-anderson
Copy link

Please try with HEAD of the 1.x branch, and, if possible, HEAD of master.

@danepowell
Copy link
Contributor Author

danepowell commented Feb 14, 2020

@greg-1-anderson thanks for the quick response. Head of 1.x is still failing, which makes sense as this commit hasn't been backported: consolidation/robo@2d2a4f6

I'm not able to test the master branch with BLT because of conflicting Symfony dependencies. Drupal 8 uses Symfony 3 and Drupal 9 uses 4.4.3, while Robo master requires 4.4.4+.

@greg-1-anderson
Copy link

Whoops, I thought I already had #922 backported to the 1.x branch, but I forgot. That's coming right up.

I'll try to loosen up some of the master branch requirements at a future date.

@greg-1-anderson
Copy link

OK, the 1.x branch now has consolidation/robo#922 on it.

@danepowell
Copy link
Contributor Author

Yay, I can confirm that Robo 1.x-dev fixes it!

@greg-1-anderson
Copy link

Cool I will make a release pretty soon.

@greg-1-anderson
Copy link

Tagged 1.4.12.

@danepowell
Copy link
Contributor Author

Woot, thanks! I'll bump our dependency on Robo to 1.4.12.

FYI, we'll try to switch to Robo 2 after updating our dependencies to support Drupal 9, and sorting out the conflict with Robo's Symfony versions.

@greg-1-anderson
Copy link

Tagged Robo 2.0.3 with slightly relaxed dependency constraints. Can be required in a project that uses the Drupal 9.0.0-alpha1 lock file.

@danepowell
Copy link
Contributor Author

This is now blocked on a new release of Drush 10, which also has a PHP 7.4 incompatibility that was recently fixed in dev: drush-ops/drush#4319

@danepowell danepowell changed the base branch from 11.x to 12.x February 21, 2020 21:33
@danepowell danepowell added the Backport needed PRs needing to be backported label Feb 21, 2020
@danepowell danepowell merged commit af478e9 into acquia:12.x Feb 27, 2020
danepowell added a commit to danepowell/blt that referenced this pull request Feb 27, 2020
* Bump Travis CI PHP version.

* Bump robo version to support php 7.4.

* debug

* Update .travis.yml

* Drush 10 php 7.4.
danepowell added a commit that referenced this pull request Feb 27, 2020
* Bump Travis CI PHP version.

* Bump robo version to support php 7.4.

* debug

* Update .travis.yml

* Drush 10 php 7.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport needed PRs needing to be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DT-1165: PHP 7.4 incompatibility
2 participants