Added search modules #374
Merged
Added search modules #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4316a45 to
6f321d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search in D8 is a finicky thing... at the moment you have to have a very specific combination of module versions (it's documented if you know to look for it, but not obvious). Since Search is a nearly universal requirement I figured it should just be in BLT. I'm trying to coordinate with various parties to break up this weird version dependency, but even so I think this is useful to have.
Also as a minor OCD nitpick, I alphabetized the packages in composer.json so we can find them more easily as the list grows. Only look at the first commit if you just want to see the search packages I added.