Multisite Test and Hook Bugfixes #3203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cquia#2581) * Fixes acquia#2580: Recent Project Update throws intimidating error. * Update Plugin.php Fix typo.
* Connects to acquia#2582: Disabling BLT commit message. * Update GitCommand.php
* Use HEAD of main Lightning branch * Trigger rebuild - packagist new deps * Trigger rebuild - packagist new deps * Trigger rebuild - packagist new deps * Trigger rebuild - packagist new deps * Require HEAD of deprecation-detector until they tag a release that allows for more versions of docblock
…cquia#2590) * Fixes acquia#2566: Allow site to be installed from existing config. * Update ConfigCommand.php * Don't change profiles.
* Fix errors in blt doctor. * Set isDrupalVmLocallyInitialized to true if command is running in the VM. * Update message with drush site:alias command.
* Removing Drupal VM command proxy. * Fix test.
* Fixes from pre-release testing. * Add chrome to Drupal VM. * Warn user forcefully when executing commands outside VM. * Do not include local.setting.php in CI envs. * Copy local.settings.php to includes.settings.php. * Try moving again.
* Do not include local.setting.php in CI envs. * Copy local.settings.php to includes.settings.php. * Try moving again. * Prevent warnings in update hook.
* Use --environment option rather than --define. * Trim = from beginning of --define value for env.
* Require PHP 7.1. * Add sudo to template .travis.yml to prevent timeout.
…al settings file template (acquia#3107)
* Update support policies * Update README.md
* Travis should test Drupal 8.7. * Disable 8.7 tests.
* Add drush cache dir utility script. * Enhanced Factory Hook to isolate db-update tasks to tempoary drush cache. * Update Factory Hooks from BLT template. * Remove redundant cache clear and rebuild to preserve drush context of current request. * Style tweaks and setting update version number to 9.2.
* Refactor post-install hook to use temp cache dir per site, use requests instead of ENV. * Refresh Factory Hooks from template for 9002001. * Update version number for hook. * Remove redundant factory hook update. * Removed unused use statements. * Style and phpcs updates.
* Fix auto detection of sites dir due to core changes. * Update proxy and host detection for core updates and Acquia VCL changes. * PHPCS fixes.
The Acquia docs link pointed to a stale page and the BLT one pointed to the 8.x branch, both throwing 404's. I've updated both to point to the latest iterations of each page.
Fixes acquia#2289 -------- Changes proposed: --------- (What are you proposing we change?) - Update composer contraint on Drupal Coder newest release (8.3.1 as of this date) - Update composer constraint on squizlabs/php_codesniffer to 3.0.1 (matching Coder) - Remove the use of a bootstrap file with PHPCS. File paths that are not allowed by filesets won't be sniffed by default. - Add a tests:phpcs:sniff:modified command to sniff unstaged modified or added files in repo for convenience.
… profile instructions. (acquia#3064)
) Fixes acquia#3214 -------- Changes proposed: --------- (What are you proposing we change?) - check if trusted_reverse_proxy_ips is defined as an array - if not, set an empty array Steps to replicate the issue: ---------- (If this PR is not fixing a defect/bug, you can remove this section.) 1. blt setup 2. bootstrap drupal Steps to verify the solution: ----------- (How does someone verify that this does what you think does?) 1. apply the patch 2. blt setup / bootstrap Drupal 3. check to ensure following warning does not appear: ``` Warning: in_array() expects parameter 2 to be array, null given in require() (line 27 of /app/vendor/acquia/blt/settings/blt.settings.php). require('/app/vendor/acquia/blt/settings/blt.settings.php') (Line: 806) require('/app/docroot/sites/naswa_main/settings.php') (Line: 125) Drupal\Core\Site\Settings::initialize('/app/docroot', 'sites/naswa_main', Object) (Line: 1056) Drupal\Core\DrupalKernel->initializeSettings(Object) (Line: 655) Drupal\Core\DrupalKernel->handle(Object) (Line: 19) ```
1cd8db8 to
d244eb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3207
Changes proposed:
Steps to replicate the issues:
To recreate errors phpunit test errors seen on https://travis-ci.org/acquia/blt/jobs/449314384#L5991-L5999:
Steps to verify the solution:
./vendor/bin/robo release:tests/ testMultisiteGenerate passes and no phpcs errors are reported (./vendor/bin/robo sniff-coderuns as part of the release:tests command)