Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3118: Update theme path to more standardized D8 defaults. #3119

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Fixes #3118: Update theme path to more standardized D8 defaults. #3119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,18 +164,18 @@ sync:
command-hooks:
# Executed when front end dependencies should be installed.
frontend-reqs:
# E.g., ${docroot}/sites/all/themes/custom/mytheme.
# E.g., ${docroot}/themes/custom/mytheme
dir: ${docroot}
# E.g., '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" && nvm use 4.4.4 && npm install'
command: null
# Executed when front end assets should be generated.
frontend-assets:
# E.g., ${docroot}/sites/all/themes/custom/mytheme.
# E.g., ${docroot}/themes/custom/mytheme
dir: ${docroot}
# E.g., '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" && nvm use 4.4.4 && npm build'
command: null
frontend-test:
# E.g., ${docroot}/sites/all/themes/custom/mytheme.
# E.g., ${docroot}/themes/custom/mytheme
dir: ${docroot}
# E.g., `npm test`.
command: null
Expand Down
6 changes: 3 additions & 3 deletions docs/frontend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ During the execution of `blt setup`, BLT will execute `command-hooks.frontend-re

command-hooks:
frontend-reqs:
dir: ${docroot}/sites/all/themes/custom/mytheme.
dir: ${docroot}/themes/custom/mytheme
command: '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" && nvm use 4.4.4 && npm install'

If you are using a sub theme of Cog, executing `npm install` in your theme directory (as exemplified above) will install all dependencies listed in [package.json](https://github.com/acquia-pso/cog/blob/8.x-1.x/STARTERKIT/package.json).
Expand All @@ -33,7 +33,7 @@ During the execution of `blt setup` and `blt artifact:deploy`, BLT will execute

command-hooks:
frontend-assets:
dir: ${docroot}/sites/all/themes/custom/mytheme.
dir: ${docroot}/themes/custom/mytheme
command: '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" && nvm use 4.4.4 && npm run build'

If you are using a sub theme of Cog, executing `npm run build` in your theme directory (as exemplified above) will execute the command defined in `scripts.build` in [package.json](https://github.com/acquia-pso/cog/blob/8.x-1.x/STARTERKIT/package.json#L51).
Expand All @@ -44,7 +44,7 @@ During the execution of `blt tests`, BLT will execute `command-hooks.frontend-te

command-hooks:
frontend-test:
dir: ${docroot}/sites/all/themes/custom/mytheme.
dir: ${docroot}/themes/custom/mytheme
command: '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" && nvm use 4.4.4 && npm test'

If you are using a sub theme of Cog, executing `npm test` in your theme directory (as exemplified above) will execute the command defined in `scripts.test` in [package.json](https://github.com/acquia-pso/cog/blob/8.x-1.x/STARTERKIT/package.json).
Expand Down