-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP for testing: SAML Config Refactor #2953
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
44f421b
Default to db storage based on environment variable.
lcatlett e02d857
Update saml config to resolve acquia function errors.
lcatlett 59015fd
Removes extra bracket.
lcatlett 38d2055
Fix syntax error.
lcatlett 48304af
Merge branch '9.x' into saml-refactor
lcatlett d11dd01
Add ACE compatibility, update helptext and Acquia docs.
lcatlett e3a50e5
Merge branch '9.x' into saml-refactor
lcatlett 95831d3
Merge branch '9.x' into saml-refactor
lcatlett 2702046
Merge branch '9.x' into saml-refactor
ba66e77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/mnt/www/html/{$_ENV['AH_SITE_GROUP']}.{$_ENV['AH_SITE_ENVIRONMENT']}/simplesamlphp/
is pointing to thesimplesamlphp
symlink in the docroot fromsymlinkDocrootToLibDir()
right? Using a relative path works and would make non-environment specific, i.e.$config['certdir'] = 'cert/';
. Same for$config['metadatadir']
on the next lineThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjgwiz I believe the simplesamlphp_auth module has a note that it requires absolute paths for those files - have you found that not to be the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lcatlett yea - in our project we have been using relative path for over a year. Currently on simplesamlphp
v1.15.4