Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2867: Cache clear errors on ACSF deploys. #2922

Merged
merged 6 commits into from
Jul 10, 2018
Merged

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Jun 29, 2018

Fixes #2867

Drush is about to introduce an environment variable that allows you to specify the cache directory: drush-ops/drush#3597

We can use this to set the cache directory to local ephemeral (block) storage rather than Gluster in order to avoid race conditions. I've verified that this fixes #2867 when using the patched version of Drush.

Ideally we would shoehorn that Drush PR into BLT somehow, but I'm not sure how to do it since we don't patch anything else in our composer.json. I suppose people who really want the patch before the next stable Drush release can apply it themselves.

@weitzman
Copy link

If you guys could also poke the Acquia Cloud to set this globally that would be much appreciated. I cant think of a downside.

@ba66e77 ba66e77 added the acsf label Jul 2, 2018
@danepowell
Copy link
Contributor Author

danepowell commented Jul 9, 2018

I've tweaked the patch to isolate caches per site, so it's pretty much "impossible" (at the risk of jinxing myself...) to run into race conditions. A few of us have tested this patch, it should be good to merge.

We're also working with Acquia Cloud to build this into the platform somehow, so that non-BLT customers can take advantage of safe caching.

@bkosborne
Copy link
Contributor

@danepowell Do you know if anything ever came of this as a platform-wide enhancement in Acquia Cloud?

@danepowell
Copy link
Contributor Author

It does look like some changes related to DRUSH_PATHS_CACHE_DIRECTORY were added to ACSF some time in 2020. I'm sorry, I can't tell you much more than that (3 years ago is ancient history to me! 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants