Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating BLT README template to include more basic info. #2735

Merged
merged 1 commit into from
May 1, 2018

Conversation

mikemadison13
Copy link
Contributor

Changes proposed:

  • Updates the README with more useful information about basic BLT workflow (and Git workflow)

* Local environment: DrupalVM
* Local drush alias: @my-project.local
* Local site URL: http://local.my-project.com
* Ensure that your computer meets the minimum installation requirements (and then install the required applications). See the [System Requirements](http://blt.readthedocs.io/en/8.x/INSTALL/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 9.x.

@mikemadison13 mikemadison13 force-pushed the readme-template branch 2 times, most recently from f6c2b14 to 00a00d2 Compare April 17, 2018 23:24
```
$ git clone git@github.com:<account>/<project>.git
```
* Add the parent repository as an upstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this already be done by the git clone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will make this clearer in regards to origin == fork and upstream == original repository

```
* Setup Local Environment

Note: Drupal VM is OPTIONAL but templated within BLT. If using Drupal VM, BLT 9 assumes all commands are run INSIDE the VM (this is a change from BLT 8).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would link to http://blt.readthedocs.io/en/9.x/readme/local-development/#using-drupal-vm-for-blt-generated-projects, which lists system level requirements for using Drupal VM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, we can then also include other locals in the future as/if we begin supporting them.

* Access the site and do necessary work at \<project local url> by running

```
$ drush @<project>.local uli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to move away from using drush aliases for the VM. This also assumes that drush is globally installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grasmash will update these. although, you still need... @self to run in the vm, right?

Note the following properties of this project:
* Primary development branch: \<branch>
* Local environment: \<local environment>
* Local drush alias: @\<project>.local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I wouldn't use a local drush alias.

* Local drush alias: @\<project>.local
* Local site URL: \<project local url>

## Working With a BLT Project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't feel like it belongs in a read me. Isn't this type of information in the onboarding doc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grasmash this level of specificity is NOT in the onboarding doc, but i'm happy to link to that in this section instead and move this detail over. i think it needs to be in our docs "somewhere" but could be convinced that "here" isn't the right place.

@mikemadison13 mikemadison13 force-pushed the readme-template branch 3 times, most recently from 452df96 to 150ccbb Compare April 20, 2018 16:03
@mikemadison13
Copy link
Contributor Author

@grasmash this should be ready for another review, i addressed all previous comments

@mikemadison13 mikemadison13 force-pushed the readme-template branch 2 times, most recently from c782ace to f9d2c98 Compare April 26, 2018 23:13
@grasmash grasmash merged commit 4939d60 into acquia:9.x May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants