Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLT-1852 assuming -y when prompting while executing something in blt #1862

Merged
merged 1 commit into from
Aug 2, 2017
Merged

BLT-1852 assuming -y when prompting while executing something in blt #1862

merged 1 commit into from
Aug 2, 2017

Conversation

alex-moreno
Copy link
Contributor

Fixes #1852 .

Changes proposed:

  • assuming -y when prompting while executing something in blt

@grasmash
Copy link
Contributor

I think that I'd prefer to fix the prompt rather than remove it.

@alex-moreno
Copy link
Contributor Author

Agree @grasmash

@alex-moreno
Copy link
Contributor Author

although I am having this issue not in Travis, but when doing blt sync to fetch remote changes to my local. I am having a look where I could fix this similarly

@alex-moreno
Copy link
Contributor Author

similarly as in your PR: grasmash@ec4779c

@grasmash
Copy link
Contributor

Are you using a non-bash shell? Can you try the command with --interactive ?

@alex-moreno
Copy link
Contributor Author

blt sync --interactive ?

It returns

[Symfony\Component\Console\Exception\RuntimeException]
The "--interactive" option does not exist.

I am using iTerm2 for Mac

@alex-moreno
Copy link
Contributor Author

interestingly, this works:

blt sync -n -y

no interactive and assume yes

@alex-moreno
Copy link
Contributor Author

alex-moreno commented Aug 2, 2017

actually this is still broken, I can only execute the command when adding the

->assume(TRUE)

line

@alex-moreno alex-moreno reopened this Aug 2, 2017
@grasmash
Copy link
Contributor

grasmash commented Aug 2, 2017

@alex-moreno Did you test 8.x?

@grasmash
Copy link
Contributor

grasmash commented Aug 2, 2017

Despite this approach being different than I would prefer, I'm going to merge it as a temporary fix. Too many people are encountering this issue and I would like to release a hot fix.

@grasmash grasmash merged commit 1181013 into acquia:8.x Aug 2, 2017
@grasmash grasmash added the Bug Something isn't working label Aug 2, 2017
@alex-moreno
Copy link
Contributor Author

yes, I tried downgrading blt and using the dev version too. Neither worked for me, but I couldn't make an intensive test

@grasmash grasmash removed the Bug Something isn't working label Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants