Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1835: provide --exclude-paths configuration key. #1846

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Fixes #1835: provide --exclude-paths configuration key. #1846

merged 1 commit into from
Jul 31, 2017

Conversation

bobbygryzynger
Copy link
Contributor

Fixes #1835.

Changes proposed:

  • allow configuration of --exclude-paths

@grasmash grasmash added the Enhancement A feature or feature request label Jul 31, 2017
@grasmash grasmash merged commit e5813e4 into acquia:8.x Jul 31, 2017
@alanoakden
Copy link

@bobbygryzynger Thanks for this, can you explain exactly where this should get configured?

@alanoakden
Copy link

@bobbygryzynger Thanks for this, can you explain exactly where this should get configured?

Ideally devs could override this by adding entries under sync: in their blt.yml

For now, I had to directly edit the build.yml file in the BLT vendor directory.

Furthermore, if you provide no exclude-paths config and comment all of that out, then the command errors as it expects some kind of exclude paths.

Therefore, I actually removed ->option('exclude-paths', implode(':', $this->getConfigValue('sync.exclude-paths'))); from vendor/acquia/blt/src/Robo/Commands/Drupal/SyncCommand.php in order to sync all CSS and JS files that I needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants